Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Update Connectable explanation #3664

Merged
merged 3 commits into from
Feb 22, 2024

Conversation

tymcauley
Copy link
Contributor

@tymcauley tymcauley commented Nov 30, 2023

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Documentation or website-related

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference).

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.5.x, 3.6.x, or 5.x depending on impact, API modification or big change: 6.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

Copy link

linux-foundation-easycla bot commented Nov 30, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@jackkoenig
Copy link
Contributor

@tymcauley can you sign the Linux Foundation CLA? We recently switched to it so that we can finish the process of Chisel being an official ChipsAlliance project.

Copy link
Contributor

@mwachs5 mwachs5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i dont think we should have changed Coerced to Child in that one part.

@tymcauley
Copy link
Contributor Author

@tymcauley can you sign the Linux Foundation CLA? We recently switched to it so that we can finish the process of Chisel being an official ChipsAlliance project.

@jackkoenig sounds like there might be a bit of a delay in getting that sorted out on my company's end. I'll let you know when I've got an ETA, but we might not be able to actually land this for a bit.

@schoeberl schoeberl added the Documentation Only changing documentation label Dec 15, 2023
Copy link
Contributor

@jackkoenig jackkoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Tynan!

@jackkoenig jackkoenig dismissed mwachs5’s stale review February 22, 2024 21:42

Questioned change was backed out

@jackkoenig jackkoenig merged commit 8d455e5 into chipsalliance:main Feb 22, 2024
14 checks passed
@tymcauley tymcauley deleted the update-connectable-docs branch February 22, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Only changing documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants