Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Instantiate for Product parameters #3210

Merged
merged 1 commit into from
Apr 25, 2023

Conversation

jackkoenig
Copy link
Contributor

Instantiate was released in 3.6.0 and 5.0.0-RC1

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Bugfix

Desired Merge Strategy

  • Squash

Release Notes

Instantiate previously erased type information for case classes and case objects which could result in incorrect behavior.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.5.x or 3.6.x depending on impact, API modification or big change: 5.0.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@jackkoenig jackkoenig added the Bugfix Fixes a bug, will be included in release notes label Apr 25, 2023
@jackkoenig jackkoenig added this to the 3.6.x milestone Apr 25, 2023
Copy link
Contributor

@debs-sifive debs-sifive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@jackkoenig
Copy link
Contributor Author

I'm going to add a couple more tests then merge this.

@jackkoenig jackkoenig force-pushed the fix-instantiate-for-case-objects branch from 169d1e4 to f049576 Compare April 25, 2023 23:38
@jackkoenig jackkoenig enabled auto-merge (squash) April 25, 2023 23:38
@jackkoenig jackkoenig merged commit 8ca8b2e into main Apr 25, 2023
@jackkoenig jackkoenig deleted the fix-instantiate-for-case-objects branch April 25, 2023 23:57
@mergify mergify bot added the Backported This PR has been backported label Apr 25, 2023
mergify bot pushed a commit that referenced this pull request Apr 25, 2023
mergify bot pushed a commit that referenced this pull request Apr 25, 2023
mergify bot added a commit that referenced this pull request Apr 26, 2023
(cherry picked from commit 8ca8b2e)

Co-authored-by: Jack Koenig <koenig@sifive.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
mergify bot added a commit that referenced this pull request Apr 26, 2023
(cherry picked from commit 8ca8b2e)

Co-authored-by: Jack Koenig <koenig@sifive.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@sequencer sequencer mentioned this pull request Jun 20, 2023
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backported This PR has been backported Bugfix Fixes a bug, will be included in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants