Allow DataView of Reset <=> [UInt<1>, AsyncReset] #3181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seldridge
referenced
this pull request
in seldridge/chisel-separable
Apr 13, 2023
Use a dummy clock and reset when instantiating a conforming module. This is necessary if the conforming module is a Module (which has the implicit clock and reset ports) as opposed to a RawModule (which does not). This is fine because all ports of the conforming module are hooked up using a DataView which will error if the clock/rest ports are not overridden. Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
Change what DataView allows in its type checking to enable Reset to be viewed as either a UInt<1> or an AsyncReset. This enables more flexible DataViews which match already allowable Chisel and FIRRTL connection semantics. Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
seldridge
force-pushed
the
dev/seldridge/DataView-reset-types
branch
from
222d6d7
to
19c64e0
Compare
jackkoenig
reviewed
Apr 15, 2023
jackkoenig
reviewed
Apr 15, 2023
core/src/main/scala/chisel3/experimental/dataview/package.scala
Outdated
Show resolved
Hide resolved
|
Review bump @jackkoenig. 😉 |
jackkoenig
approved these changes
May 5, 2023
This was referenced May 5, 2023
mergify bot
pushed a commit
that referenced
this pull request
May 5, 2023
Change what DataView allows in its type checking to enable Reset to be viewed as either a UInt<1> or an AsyncReset. This enables more flexible DataViews which match already allowable Chisel and FIRRTL connection semantics. Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com> (cherry picked from commit 44ce96c)
mergify bot
pushed a commit
that referenced
this pull request
May 5, 2023
Change what DataView allows in its type checking to enable Reset to be viewed as either a UInt<1> or an AsyncReset. This enables more flexible DataViews which match already allowable Chisel and FIRRTL connection semantics. Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com> (cherry picked from commit 44ce96c)
mergify bot
added a commit
that referenced
this pull request
May 5, 2023
Change what DataView allows in its type checking to enable Reset to be viewed as either a UInt<1> or an AsyncReset. This enables more flexible DataViews which match already allowable Chisel and FIRRTL connection semantics. Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com> (cherry picked from commit 44ce96c) Co-authored-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
mergify bot
added a commit
that referenced
this pull request
May 6, 2023
Change what DataView allows in its type checking to enable Reset to be viewed as either a UInt<1> or an AsyncReset. This enables more flexible DataViews which match already allowable Chisel and FIRRTL connection semantics. Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com> (cherry picked from commit 44ce96c) Co-authored-by: Schuyler Eldridge <schuyler.eldridge@sifive.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change what DataView allows in its type checking to enable Reset to be viewed as either a UInt<1> or an AsyncReset. This enables more flexible DataViews which match already allowable Chisel and FIRRTL connection semantics.
Release Notes
Change what DataView allows in its type checking to enable Reset to be viewed as either a UInt<1> or an AsyncReset. This enables more flexible DataViews which match already allowable Chisel and FIRRTL connection semantics.