-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print warning when extractor is too wide or narrow #3033
Print warning when extractor is too wide or narrow #3033
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but I have some comments. I'd also like to see an FAQ page for these errors to tell people how to resolve them (using .pad
or a bit extract, or both in the case of a generator where the width may be too large or too small under different circumstances).
I noticed that the error message for zero-width extractee is printing twice. once from the dynamic index and then again when it does
Is it fine to change the message back to just |
Co-authored-by: Jack Koenig <jack.koenig3@gmail.com>
9c5dc6b
to
d40a6a3
Compare
Co-authored-by: Jack Koenig <jack.koenig3@gmail.com>
This relates to #2946 |
Contributor Checklist
docs/src
?Type of Improvement
API Impact
none
Backend Code Generation Impact
none
Desired Merge Strategy
Squash
Release Notes
Warn when dynamic extract index is too wide or too narrow.
Reviewer Checklist (only modified by reviewer)
3.4.x
, [small] API extension:3.5.x
, API modification or big change:3.6.0
)?Enable auto-merge (squash)
, clean up the commit message, and label withPlease Merge
.Create a merge commit
.