-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Utils: add source locators #2496
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackkoenig
reviewed
Apr 19, 2022
For example this is now the output for the test added in
before this change:
|
jackkoenig
reviewed
Apr 19, 2022
mwachs5
commented
Apr 20, 2022
jackkoenig
reviewed
Apr 21, 2022
mwachs5
force-pushed
the
cat-sourcelocators
branch
from
April 21, 2022 21:10
ae3f33a
to
7994b88
Compare
chick
approved these changes
Apr 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I did not go deep in analysis
but code reads well and tests look good
mwachs5
added
the
Please Merge
Accepted PRs that are ready to be merged. Useful when waiting on CI.
label
Apr 29, 2022
sequencer
added a commit
to chipsalliance/rocket-chip
that referenced
this pull request
May 13, 2022
sequencer
added a commit
to chipsalliance/rocket-chip
that referenced
this pull request
May 13, 2022
sequencer
added a commit
to OpenXiangShan/XiangShan
that referenced
this pull request
May 25, 2022
poemonsense
pushed a commit
to OpenXiangShan/XiangShan
that referenced
this pull request
May 26, 2022
jackkoenig
pushed a commit
that referenced
this pull request
Feb 28, 2023
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor Checklist
docs/src
?Type of Improvement
API Impact
This adds implicits to Cat, Reg utils and Bitwise Utils. Which I think is a backwards-incompatible API change though no user code should actually have to change.
I renamed one of the SourceInfoTransform functions to match the pattern where we make it match the name of the arguments exactly, and had to update Mem.scala to match.
Backend Code Generation Impact
The resulting code will have more useful source locators for any utils.
Desired Merge Strategy
Release Notes
Add source locators for util functions Cat, those in Bitwise, and those in Reg
Reviewer Checklist (only modified by reviewer)
3.4.x
, [small] API extension:3.5.x
, API modification or big change:3.6.0
)?Please Merge
?