[WORKFLOW] Fix: enhance the timestamp exception to accommodate pure documentation PR's #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebofearth
force-pushed
the
cwhitehead-msft-pr-doc-ignore-fix
branch
from
99abe48 to
78114ce
Compare
calebofearth
force-pushed
the
cwhitehead-msft-pr-doc-ignore-fix
branch
from
dc96ef9 to
3e2d23b
Compare
calebofearth
force-pushed
the
cwhitehead-msft-pr-doc-ignore-fix
branch
from
3e2d23b to
b2fb533
Compare
…x' with updated timestamp and hash after successful run
calebofearth
changed the title
Nitsirks
approved these changes
Jun 27, 2024
nileshbpat
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Pull Request workflow, the timestamp exception does not correctly skip the timestamp check when the current feature branch contains only documentation updates all the way back to where it diverged from main. This is because the last commit to main that DOES contain design changes was merged with the squash method, making a brand new commit that is much newer than the actual timestamp commit. If that commit was merged to main, though, presumably all the checks passed at that time.