-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation update for RDC #511
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add tool versions for RDC analysis to the README?
EDIT: Looks like this was done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Edits for style, clarity, punctuation, and typos.
348688a
@amullick007 looks like you'll need to merge from main to resolve the conflict on pr_hash/pr_timestamp. |
I resolved the merge conflicts. Since I am not very familiar with Git, it took me few iterations to do this. Can you please check if the changes look good? |
Merge looks a little funky, but seems like you caught all the file updates so I think it's good. |
The merge-base changed after approval.
The merge-base changed after approval.
All checks have passed, @steph-morton , @Nitsirks Can you please approve this PR. |
The merge-base changed after approval.
@amullick007 any idea what's going on with all these merge-base messages? It seems like approvals are being auto-dismissed for no reason. |
no idea :( shall I create a new PR? Even though I am seeing that only 1 pending reviewer is left. Once @steph-morton approves the review, lets see it it allows to merge |
The merge-base changed after approval.
We may not need to abandon this PR just yet.
This should essentially start over from scratch and replay all your edits onto this same branch, then re-stamp it. |
Thanks for the fixups Avirup. Looks like it's good now. I'll merge once the checks finish. |
No description provided.