Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trigger logic tests in LSU #224

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

kiryk
Copy link
Collaborator

@kiryk kiryk commented Aug 13, 2024

The PR extends verification tests of LSU. A similar test was already used in DEC.

Comment on lines +25 to +26
input logic [31:0] lsu_addr_m, // address
input logic [31:0] store_data_m, // store data

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[verible-verilog-format] reported by reviewdog 🐶

Suggested change
input logic [31:0] lsu_addr_m, // address
input logic [31:0] store_data_m, // store data
input logic [31:0] lsu_addr_m, // address
input logic [31:0] store_data_m, // store data

input logic [31:0] lsu_addr_m, // address
input logic [31:0] store_data_m, // store data

output logic [3:0] lsu_trigger_match_m // match result

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[verible-verilog-format] reported by reviewdog 🐶

Suggested change
output logic [3:0] lsu_trigger_match_m // match result
output logic [3:0] lsu_trigger_match_m // match result

Comment on lines +45 to +49
assign lsu_pkt_m.word = 1; // lsu_word;
assign lsu_pkt_m.half = 1; // lsu_half;
assign lsu_pkt_m.dma = 0; // lsu_dma;
assign lsu_pkt_m.valid = 1; // lsu_valid;
assign lsu_pkt_m.store = 1; // lsu_store;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[verible-verilog-format] reported by reviewdog 🐶

Suggested change
assign lsu_pkt_m.word = 1; // lsu_word;
assign lsu_pkt_m.half = 1; // lsu_half;
assign lsu_pkt_m.dma = 0; // lsu_dma;
assign lsu_pkt_m.valid = 1; // lsu_valid;
assign lsu_pkt_m.store = 1; // lsu_store;
assign lsu_pkt_m.word = 1; // lsu_word;
assign lsu_pkt_m.half = 1; // lsu_half;
assign lsu_pkt_m.dma = 0; // lsu_dma;
assign lsu_pkt_m.valid = 1; // lsu_valid;
assign lsu_pkt_m.store = 1; // lsu_store;

Comment on lines +52 to +54
el2_lsu_trigger tu (
.*
);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[verible-verilog-format] reported by reviewdog 🐶

Suggested change
el2_lsu_trigger tu (
.*
);
el2_lsu_trigger tu (.*);

@kiryk kiryk force-pushed the increase-tl-coverage branch 5 times, most recently from 27f805e to 2675bce Compare August 13, 2024 11:34
Copy link

Links to coverage and verification reports for this PR (#224) are available at https://chipsalliance.github.io/Cores-VeeR-EL2/

@kiryk kiryk marked this pull request as ready for review August 27, 2024 08:19
Copy link

Links to coverage and verification reports for this PR (#224) are available at https://chipsalliance.github.io/Cores-VeeR-EL2/

@tmichalak
Copy link
Collaborator

LGTM

@tmichalak tmichalak merged commit f40708a into chipsalliance:main Aug 27, 2024
404 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants