Fix Logic behind Version Check #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed logic behind checking a repo version.
QuatZo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed logic behind checking a repo version.
Before: If request successfuly retrieved latest version tag, then no matter of installed version people in SWEX would get You have the latest version v[xxx]. Variable newest wasn't used anywhere.
After: Variable newest (as expected) checks if current & latest versions are the same. If they are, SWEX prints You have the latest version v[xxx]. If no, then prints Your current version is v[xxx] and the latest version is v[yyy] Click here to download the latest version.. Link works as intended.