Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(error handler): re-throw http-proxy missing target error #517

Merged
merged 1 commit into from
Apr 6, 2021
Merged

fix(error handler): re-throw http-proxy missing target error #517

merged 1 commit into from
Apr 6, 2021

Conversation

chimurai
Copy link
Owner

@chimurai chimurai commented Apr 6, 2021 •
edited
Loading

Background:
With router usage and optional target (#512); Required target for http-proxy can sometimes be empty.

This PR will re-throw the error emitted from http-proxy.

req and res object are empty, so there is no graceful way to handle this error...

In these cases it recommended to set target as fallback.

@chimurai chimurai merged commit 030ea2e into master Apr 6, 2021
@chimurai chimurai deleted the fix-error-missing-target branch April 6, 2021 19:24
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.08%) to 87.302% when pulling 1eb6a85 on fix-error-missing-target into 40e8763 on master.

@punehim punehim mentioned this pull request Sep 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chimurai @coveralls