-
Notifications
You must be signed in to change notification settings - Fork 840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
return 504, 502 and 500 as appropriate Fixes #131 #132
Conversation
Nice, looks good. I'm wondering if this would be a breaking change. It could be breaking if someone relies on the 500 status being returned. |
@SpaceK33z not a breaking change over HTTP. The HTTP spec is very clear that servers can return these error codes, and clients should support them. Any client that does a hardcoded detection of '500' is not HTTP compliant, and should expect to be broken. |
@chimurai woop it's green now |
Thanks for the PR @graingert. Definitely a better usage of the http status codes. Don't mind if this PR breaks existing hardcoded detection because of this improvement. This So if someone still wants to rely on the hardcoded Some background info why this default error handler exists. From the
|
published in hope this doesn't cause much regression :) |
Awesome @chimurai :). |
No description provided.