fix(beam): properly re-center HA grid after unwrapping long transits #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljgray
approved these changes
Aug 19, 2024
| @@ -1278,9 +1278,9 @@ def unwrap_lha(lsa, src_ra): | |||
| lsa += start_lsa | |||
| # subtract source RA | |||
| return np.where( | |||
| np.abs(lsa - src_ra) < np.abs(lsa - src_ra + 360.0), | |||
| np.abs(lsa - src_ra) < np.abs(lsa - (src_ra + 360.0)), | |||
There was a problem hiding this comment.
I don't think that the brackets here are actually necessary
ssiegelx
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where the HA coordinate of very long transits (~180 degrees) would not be properly re-centered about HA=0, causing the holography regridder (
ch_pipeline.analysis.beam.TransitRegridder) to silently fail, returning a stream of 0s in the output. See the attached plot for an example of the old and new behavior for a long transit of Tau A (RA ~ 83) which wraps at 360 degrees.