Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(hfb): add Doppler shift for HFB ringmap #230

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(hfb): add Doppler shift for HFB ringmap #230

wants to merge 1 commit into from

Conversation

rikvl
Copy link
Contributor

@rikvl rikvl commented Jan 16, 2024

Currently looping over ra and el axes.

@rikvl rikvl requested review from jrs65 and arashcosmology January 16, 2024 16:08
@rikvl
feat(hfb): add Doppler shift for HFB ringmap
f75c8e4 
Currently looping over `ra` and `el` axes.
@rikvl rikvl force-pushed the rvl/hfb-ringmap-doppler branch from 1cdee2f to f75c8e4 Compare January 29, 2024 19:24
@rikvl
Copy link
Contributor Author

rikvl commented Jun 7, 2024

Maybe it's better to avoid looping over ra and el. By evaluating at a single time this can be avoided. Doppler shift due to Earth's motion may vary slow enough that we only need one evaluation per day/week. See if performance requires this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrs65 jrs65 Awaiting requested review from jrs65

@arashcosmology arashcosmology Awaiting requested review from arashcosmology

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rikvl