Add option to disable touch #133
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for taking the time to create a pull-request. The latest release of this module includes a new option "disableTouch" and behaves similarly as implemented by your PR here. |
|
Great! Glad it was helpful |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were having significant scaling problems using express-mysql-session and were considering switching to a different express-session storage adapter. I noticed this adapter https://www.npmjs.com/package/connect-session-sequelize had a disable touch parameter. We have rolled this out in production and it reduced our session DB load by 75%. Obviously every case is unique, we have very long sessions and the session is modified and update quite frequently already so this setting made sense for us.