Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show the filled character instead of an outline #27

Closed
ehdwns980416 opened this issue Mar 2, 2023 · 6 comments · Fixed by #87
Closed

Show the filled character instead of an outline #27

ehdwns980416 opened this issue Mar 2, 2023 · 6 comments · Fixed by #87

Comments

@ehdwns980416
Copy link

How to show users a preview before showing the stroke animation?

image
@Mr-Pepe
Copy link
Collaborator

Mr-Pepe commented Mar 4, 2023

A preview of what exactly?

@ehdwns980416
Copy link
Author

@Mr-Pepe I want to show the shape of the letter in a filled color, not an outline.

@Mr-Pepe
Copy link
Collaborator

Mr-Pepe commented Mar 6, 2023

Got it. Do you want to still have an additional outline? The feature would be a nice one but I don't think that I'll find the time to implement it anytime soon. For the time being, you could maybe draw the same character twice, with one drawing onto the other.

@Mr-Pepe Mr-Pepe changed the title placeholder stroke color Show the filled character instead of an outline Mar 6, 2023
@ehdwns980416
Copy link
Author

That's great! I can use showFullCharacter() for the base character, right?

@Mr-Pepe
Copy link
Collaborator

Mr-Pepe commented Mar 7, 2023

Yes, that should work. You can give it the color you want by setting the strokeColor.

Mr-Pepe added a commit that referenced this issue Jun 6, 2024
@Mr-Pepe
feat: Add showBackground and backgroundColor attributes
311cc20 
Enables giving a character a solid background in a different color.
This prevents clutter when the character is drawn
on top of a background with guides or other elements.

Closes: #27
@Mr-Pepe Mr-Pepe linked a pull request Jun 6, 2024 that will close this issue
feat: Add showBackground and backgroundColor attributes #87
Merged
@Mr-Pepe
Copy link
Collaborator

Mr-Pepe commented Jun 6, 2024

@ehdwns980416 I don't know if this is still relevant to you, but the feature is available in version 3.2.0 🙂

Simply set showBackground: true when creating the StrokeOrderAnimationController or call setShowBackground(true) on it. You can set the color via backgroundColor.

@Mr-Pepe Mr-Pepe closed this as completed Jun 6, 2024
@Mr-Pepe Mr-Pepe mentioned this issue Aug 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add showBackground and backgroundColor attributes chill-chinese/stroke-order-animator
2 participants
@ehdwns980416 @Mr-Pepe