-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Satellite Imagery of All Fossil Power Plants #203
Conversation
✅ Deploy Preview for decarb-my-state ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@derekeder - we discussed you making a python script so we can now have power plant pages at say |
This reverts commit 5ab6e17.
…t/decarbonize-my-state into power-plant-map-imgs
@JoseMRodriguezO looks like we're missing your script and the images. Looks like you reverted a commit that had the script in this commit 9c11664. Can you add it back, as well as the 3,500 images? |
commit updated |
OverviewThis pull request adds functionality to fetch power plant data from a JSON file and save map images for each power plant using the Google Static Maps API. Closes #203 DemoNotesAdded code to read power plant data from a JSON file.
Testing InstructionsEnsure the necessary dependencies, such as
|
@JoseMRodriguezO cool - looks like the images are here! nice! @vkoves the images are in the data folder. do you want to update this PR and move them to the static directory and link to them on the power plant detail page? |
1 similar comment
@JoseMRodriguezO cool - looks like the images are here! nice! @vkoves the images are in the data folder. do you want to update this PR and move them to the static directory and link to them on the power plant detail page? |
Want to note that this is on my radar and I know I need to get back to this 😆 |
@derekeder and @JoseMRodriguezO - I've integrated the power plant imagery onto the power plant details page, but there's a few things I noticed. First, here's what I have right now: So what I noticed:
|
ok, I will work on it |
@JoseMRodriguezO - we can talk about it on Tuesday, I think we need to use a tool like ImageMagick to locally compress all the images, but not sure about reducing which power plants we have. If you do want to take a crack at it, this is what I found: My internal target is < 200 KB per image, but if we could get 100 KB that'd be great. https://squoosh.app/ seems to be able to do that without it looking terrible |
Hi, Viktor I just finished with imageMagic. I just resize the images to low 200kb at 600x600 I just need to commit now, also separated the plants by category as requested. |
@JoseMRodriguezO - can you post a before after image with one of your images before and after compression? What does the total directory size come out to? |
@JoseMRodriguezO - that sounds awesome! Can you push up the new images? |
Sorry I've dropped the ball on this, I need to get the styling fixed up and then get someone to review this! It's on my list 😆 |
@derekeder - this is still waiting on you, it's ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
love it - lets bring it in!
Overview
Adds satellite images to all power plants do you can see how large a plant is and understand it's environment.
Closes #xxx
Demo
Optional. Screenshots,
curl
examples, etc.Notes
Optional. Ancillary topics, caveats, alternative strategies that didn't work out, anything else.
Testing Instructions