Fix scoped package identification #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@CreativeTechGuy thank you for your PR, I will review asap! |
|
@chiefmikey Hi have you gotten a chance to review? I'd love this to get fixed so we can use this package. |
|
@CreativeTechGuy sorry for the delay, thanks so much for your PR! Released in https://github.com/chiefmikey/eslint-plugin-disable-autofix/releases/tag/v4.2.0 |
|
Thank you! It works great. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The conditions that were being checked previously to find eslint-plugins in scoped packages was incorrect.
Updated plugin to use the naming requirements mentioned here: https://eslint.org/docs/latest/extend/plugins#name-a-plugin
Example of eslint-plugin which wasn't previously getting picked up before this change. https://www.npmjs.com/package/@nx/eslint-plugin