Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update Project to .NET 8.0 and Resolve Associated Warnings #75

Merged

Conversation

stranne
Copy link
Contributor

@stranne stranne commented Aug 15, 2024

.NET 6.0 reaches end of support on November 12, 2024. This pull request updates the projects to .NET 8.0, which is supported until November 10, 2026.

This pull request includes:

  1. Updated Target Framework: The project has been updated from .NET 6.0 to .NET 8.0 to ensure continued support and access to the latest features and improvements.
  2. Resolved Build Warnings: Addressed warnings introduced by the .NET 8.0 update to maintain a clean build process.
  3. Resolved IDE Code Style Warnings: Fixed various IDE code style warnings to align with recommended practices and improve code maintainability.

Please review the changes and provide any feedback. If there are concerns about specific warnings or if any should be handled differently, such as being ignored, I’m open to suggestions.

@jolexxa
Copy link
Member

jolexxa commented Aug 16, 2024

Not entirely sure why yet, but there seem to be a lot of CI failures on this and #73. If we can get this passing, it should be fine to merge!

@stranne stranne force-pushed the feature/update-dotnet6-to-dotnet8 branch from 7e9ed0e to 3ef62a1 Compare August 16, 2024 10:26
@stranne stranne force-pushed the feature/update-dotnet6-to-dotnet8 branch from 3ef62a1 to 23f9ef9 Compare August 16, 2024 10:34
@stranne
Copy link
Contributor Author

stranne commented Aug 16, 2024

I've fixed the CI issues for both pull requests. Surprisingly, one issue specific to Mac OS X was resolved just by adding quotation marks. I find it odd that updating the .NET version could introduce that kind of issue.

Please feel free to provide any feedback or suggestions before we merge.

@jolexxa
Copy link
Member

jolexxa commented Aug 17, 2024

Thank you so much, I really appreciate everything you've done!!

@jolexxa jolexxa merged commit f1a0962 into chickensoft-games:main Aug 17, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants