Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.3 images #120

Merged
merged 2 commits into from
Jan 30, 2024
Merged

PHP 8.3 images #120

merged 2 commits into from
Jan 30, 2024

Conversation

le0m
Copy link
Member

@le0m le0m commented Nov 30, 2023

This PR adds PHP 8.3 images.

Release announcement


EDIT: latest release of Imagick fails randomly to build for PHP 8.3 on alpine/amd64; waiting for them to tag a new release

Imagick/imagick#643
Imagick/imagick#630 (comment)
mlocati/docker-php-extension-installer#811

@le0m le0m marked this pull request as draft November 30, 2023 16:59
@Mushoz
Copy link

Mushoz commented Jan 30, 2024

From my understanding, the master branch of imagick works fine, but there hasn't been a release in ~2 years. There doesn't look to be any upstream activity regarding this issue and tagging a new release. At what point should we look for alternative solutions? Either by applying some workaround, or by getting rid of imagick from these images altogether? Not having php 8.3 support is a pretty big downside, especially since not all images are currently failing. What are your thoughts on this?

@le0m
Copy link
Member Author

le0m commented Jan 30, 2024

I was delaying this hoping that Imagick's devs would care to tag a new version, but as 3 months passed without any sign of them caring about this issue (namely, release a new version of the library like any normal library/project has done in the last 3/4 decades) it seems the time has come.

I'll implement a workaround in the coming days, sorry for the delay.

@Mushoz
Copy link

Mushoz commented Jan 30, 2024

Don't worry about the delay! As you already said yourself, this is all due to the lack of a new version on imagick's side. But I am glad to see there is going to be a workaround, so that we can get php 8.3 versions of these images. Thanks a lot!

@le0m le0m marked this pull request as ready for review January 30, 2024 14:20
@le0m le0m merged commit 82379d4 into main Jan 30, 2024
49 checks passed
@le0m le0m deleted the php-8.3 branch January 30, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants