-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add KYTEA_DIR environment variable to build with kytea at arbitrary path #20
Conversation
@maxhgerlach Thanks for your contribution. Can you check CI failure? |
Hi @chezou, the failure doesn't obviously look related to my change:
Apparently it couldn't reach some CentOS repository to install |
Ah, okay. Let me take a look. |
It turns out the issue was observed in another repository. Let me wait until it recovers. |
Made a change to build arm64 wheels. Can you rebase to current master branch? |
@maxhgerlach btw, I've released new version including arm64 wheel. Let me know if it works on your environment. https://pypi.org/project/kytea/0.1.7/ |
CI passed 🎉 Will merge. |
Hi @chezou, sorry for the delay... Thanks so much for merging this and releasing M1-compatible wheels! I can confirm that version 0.1.7 from PyPI works fine on my Mac (Python 3.9 built for arm64, macOS 12.2). |
Thanks for your confirming! Appreciate it! |
Oops, actually I think I messed up before, actually I am getting import errors. The wheel should be independent of a system install of the kytea C++ library, right?
|
Hmm, looks like the wheel doesn't work properly. Unfortunately, I don't have M1 mac, so I'm not sure why delocate doesn't work appropriately. |
@maxhgerlach Nvm, I confirmed another person that he can't import with the wheel. Will drop the arm64 wheel later. |
Since there is a report that arm64 wheel doesn't work properly, stop building arm64 macOS wheel. #20 (comment) This may be an issue around repair wheel with delocate, but can't tackle it since the maintainer doesn't have the environment. https://cibuildwheel.readthedocs.io/en/stable/faq/#macos-passing-dyld_library_path-to-delocate
Oof, cibuildwheel seems to be quite tricky indeed on macOS. Would it help maybe to link Kytea statically to avoid the intricacies needed for delocate-wheel? Homebrew at least provides a
|
Since I don't have M1 mac so I can't test, but I guess the root cause is same as fugashi facing polm/fugashi#55 (comment) |
This change would enable me to build this wrapper on my Mac (arm64-based) via