Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made the blogs section responsive while keeping initial design. #44

Merged
merged 2 commits into from
Jul 6, 2022

Conversation

Aryan3212
Copy link
Contributor

I kept the 3-column layout for large screens and reduced column number as screen decreases on the blogs page.

Laptop and above:
image

Tablet:
image

Mobile:
image

@netlify
Copy link

netlify bot commented Jul 1, 2022

Deploy Preview for react-portfolio-template ready!

Name Link
🔨 Latest commit 06079a3
🔍 Latest deploy log https://app.netlify.com/sites/react-portfolio-template/deploys/62c50035b86b8e000843bb4a
😎 Deploy Preview https://deploy-preview-44--react-portfolio-template.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Aryan3212
Copy link
Contributor Author

There might be some issues with code styling. I can fix those and re-commit.

<div className="mt-10">
<h1
ref={text}
className="mx-auto text-6xl mob:text-6xl laptop:text-8xl mob:p-2 text-bold w-full mob:w-full laptop:w-4/5"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can take out mob:text-6xl and mob:w-full as we have them as default.
what do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup that makes sense, I'll work on that.

Copy link
Contributor Author

@Aryan3212 Aryan3212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made the changes mentioned. Please have a look.

@chetanverma16 chetanverma16 merged commit f5d43d2 into chetanverma16:main Jul 6, 2022
@chetanverma16
Copy link
Owner

Nice Work!!

@chetanverma16 chetanverma16 linked an issue Jul 6, 2022 that may be closed by this pull request
@Aryan3212
Copy link
Contributor Author

Thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Blog Responsive
2 participants