Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require Python 3.6 #339

Closed
wants to merge 16 commits into from
Closed

Require Python 3.6 #339

wants to merge 16 commits into from

Conversation

jaraco
Copy link
Member

@jaraco jaraco commented Nov 24, 2020 •
edited by rtd-helper bot
Loading

❓ What kind of change does this PR introduce?

  • 💥 other

📋 What is the related issue number (starting with #)

Resolves #252

Currently blocked on stability fixes identified in that bug.

This change is Reviewable

URL of RTD document: https://cheroot.readthedocs.io/en/debt-py36/ Documentation Status

@lgtm-com

This comment has been minimized.

Sign in to view
@lgtm-com

This comment has been minimized.

Sign in to view
@lgtm-com

This comment has been minimized.

Sign in to view
webknjaz
webknjaz reviewed Nov 24, 2020
View reviewed changes
.travis.yml Outdated Show resolved Hide resolved
webknjaz
webknjaz reviewed Nov 24, 2020
View reviewed changes
cheroot/_compat.py Outdated Show resolved Hide resolved
webknjaz
webknjaz reviewed Nov 24, 2020
View reviewed changes
cheroot/_compat.py Outdated Show resolved Hide resolved
@lgtm-com

This comment has been minimized.

Sign in to view
@lgtm-com

This comment has been minimized.

Sign in to view
webknjaz
webknjaz reviewed Nov 25, 2020
View reviewed changes
cheroot/server.py Outdated Show resolved Hide resolved
@lgtm-com
Copy link

lgtm-com bot commented Nov 25, 2020

This pull request fixes 4 alerts when merging 84ffe09 into c99085a - view on LGTM.com

fixed alerts:

  • 3 for Unused import
  • 1 for Unused local variable

Safihre
Safihre reviewed Nov 27, 2020
View reviewed changes
cheroot/connections.py Outdated Show resolved Hide resolved
@jaraco jaraco mentioned this pull request Dec 5, 2020
Closed
3 tasks
jaraco added a commit that referenced this pull request Dec 5, 2020
@jaraco
Update changelog. Ref #339.
693e5df
@jaraco jaraco changed the title Drop support for Python older than 3.6 Require Python 3.6 Dec 5, 2020
@jaraco jaraco marked this pull request as ready for review December 5, 2020 16:57
@jaraco
Copy link
Member Author

jaraco commented Dec 5, 2020

Ugh. So it seems that adding a changelog entry breaks the CI and blocks running tests.

@lgtm-com
Copy link

lgtm-com bot commented Dec 5, 2020

This pull request fixes 4 alerts when merging 4e90f80 into 6b10c6c - view on LGTM.com

fixed alerts:

  • 3 for Unused import
  • 1 for Unused local variable

@jaraco jaraco mentioned this pull request Dec 5, 2020
Closed
@lgtm-com
Copy link

lgtm-com bot commented Dec 5, 2020

This pull request fixes 4 alerts when merging 14a8262 into 6b10c6c - view on LGTM.com

fixed alerts:

  • 3 for Unused import
  • 1 for Unused local variable

@lgtm-com
Copy link

lgtm-com bot commented Dec 5, 2020

This pull request fixes 4 alerts when merging 05b7e94 into 6b10c6c - view on LGTM.com

fixed alerts:

  • 3 for Unused import
  • 1 for Unused local variable

@webknjaz
Copy link
Member

webknjaz commented Dec 6, 2020

@jaraco I believe that adding a changelog title will only break the sphinx checks and since linter'ish jobs are in a separate workflow, they won't block tests (but still be annoying).

@webknjaz
Copy link
Member

I'm going to rebase this.

webknjaz pushed a commit that referenced this pull request Dec 10, 2020
@jaraco @webknjaz
Update changelog. Ref #339.
b4af41f
@lgtm-com
Copy link

lgtm-com bot commented Dec 10, 2020

This pull request fixes 4 alerts when merging 0c997cc into 577da25 - view on LGTM.com

fixed alerts:

  • 3 for Unused import
  • 1 for Unused local variable

webknjaz pushed a commit that referenced this pull request Dec 10, 2020
@jaraco @webknjaz
Add a changelog entry for v9.0.0
12e53a2 
Ref #339

N.B. The version title is disabled for now until the release
is ready to be cut.
@lgtm-com
Copy link

lgtm-com bot commented Dec 10, 2020

This pull request fixes 4 alerts when merging 8cfcc9a into 577da25 - view on LGTM.com

fixed alerts:

  • 3 for Unused import
  • 1 for Unused local variable

webknjaz pushed a commit that referenced this pull request Dec 10, 2020
@jaraco @webknjaz
Add a changelog entry for v9.0.0
38d8b5c 
Ref #339

N.B. The version title is disabled for now until the release
is ready to be cut.
webknjaz pushed a commit that referenced this pull request Dec 11, 2020
@jaraco @webknjaz
Add a changelog entry for v9.0.0
73ba888 
Ref #339

N.B. The version title is disabled for now until the release
is ready to be cut.
@lgtm-com
Copy link

lgtm-com bot commented Dec 11, 2020

This pull request fixes 4 alerts when merging 73ba888 into f7d2df9 - view on LGTM.com

fixed alerts:

  • 3 for Unused import
  • 1 for Unused local variable

webknjaz pushed a commit that referenced this pull request Dec 13, 2020
@jaraco @webknjaz
Add a changelog entry for v9.0.0
9ba742d 
Ref #339

N.B. The version title is disabled for now until the release
is ready to be cut.
@lgtm-com
Copy link

lgtm-com bot commented Dec 13, 2020

This pull request fixes 4 alerts when merging 9ba742d into 0341a0b - view on LGTM.com

fixed alerts:

  • 3 for Unused import
  • 1 for Unused local variable

webknjaz and others added 16 commits January 18, 2021 15:03
@webknjaz
Add a py2-drop banner to the docs
6cb106c
@jaraco @webknjaz
Remove declared support for Python < 3.6
3d0454b 
This change drops the corresponding CPython (2.7, 3.4, 3.5)
and PyPy (2.7) versions from the CI matrix and Python
distribution package metadata.
@jaraco @webknjaz
Remove compatibility code from wsgi
d5d5252
@jaraco @webknjaz
Remove compatibility code from cheroot
fca148d
@jaraco @webknjaz
Remove compatibility code from cli
b51f5f7
@jaraco @webknjaz
Remove compatibility code from connections
66d5c93
@jaraco @webknjaz
Remove compatibility code from errors
02ca605
@jaraco @webknjaz
Remove compatibility code from makefile
be77665
@jaraco @webknjaz
Remove compatibility code from test__compat
a149423
@jaraco @webknjaz
Remove compatibility code from server
2710601 
Co-authored-by: Sviatoslav Sydorenko <sviat@redhat.com>
@jaraco @webknjaz
Remove compatibility code from testing
3b279da
@jaraco @webknjaz
Remove compatibility code from threadpool
98c8f70
@jaraco @webknjaz
Remove compatibility code from ssl package
9c4f458
@jaraco @webknjaz
Remove compatibility code from test package
c49470a
@jaraco @webknjaz
Remove Python 3.5 compatibility from _compat module
4b465ee
@jaraco @webknjaz
Add a changelog entry for v9.0.0
ad66ace 
Ref #339

N.B. The version title is disabled for now until the release
is ready to be cut.
@lgtm-com
Copy link

lgtm-com bot commented Jan 18, 2021

This pull request fixes 4 alerts when merging ad66ace into ff630b1 - view on LGTM.com

fixed alerts:

  • 3 for Unused import
  • 1 for Unused local variable

@jaraco

This comment has been minimized.

Sign in to view
@cherrypy cherrypy deleted a comment from falloutcoder Dec 5, 2021
@jaraco
Copy link
Member Author

jaraco commented Dec 5, 2021

This looks stale. Closing.

@jaraco jaraco closed this Dec 5, 2021
@webknjaz
Copy link
Member

webknjaz commented Dec 5, 2021

@jaraco FTR this is still on my radar, just focusing on a few other things at the moment. I'm working on a reusable workflow for tox that has the potential to considerably simplify the maintenance of CIs across hundreds of projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Safihre Safihre Safihre left review comments

@webknjaz webknjaz webknjaz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dropping support for Python 2 and Python 3 below 3.5
3 participants
@jaraco @webknjaz @Safihre