Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(proto): Proto API v2 [DEV-1786] #398

Merged
merged 28 commits into from
Oct 26, 2022
Merged

feat(proto): Proto API v2 [DEV-1786] #398

merged 28 commits into from
Oct 26, 2022

Conversation

askolesov
Copy link
Contributor

No description provided.

@ankurdotb ankurdotb changed the title Proto API v2 feat(proto): Proto API v2 Oct 3, 2022
@askolesov askolesov marked this pull request as ready for review October 5, 2022 08:38
ankurdotb
ankurdotb previously approved these changes Oct 5, 2022
View reviewed changes
@ankurdotb ankurdotb changed the title feat(proto): Proto API v2 feat(proto): Proto API v2 [DEV-1786] Oct 5, 2022
@ankurdotb
Copy link
Contributor

Task linked: DEV-1786 Build and lint Protobuf definitions for v2

@askolesov askolesov requested a review from ankurdotb October 5, 2022 12:03
ankurdotb
ankurdotb requested changes Oct 7, 2022
View reviewed changes
Eengineer1
Eengineer1 reviewed Oct 7, 2022
View reviewed changes
Copy link
Contributor

@Eengineer1 Eengineer1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added revisited FeeParams definitions for interchangeability through gov proposals.

We need to mind for tx_types to be snake cased or defined per MsgTypeUrl.
As for resources, media_types keys can easily be valid mime types.

@askolesov
Copy link
Contributor Author

Processed the rest of comments. I think it's ready now.

Andrew Nikitin and others added 4 commits October 14, 2022 16:40
@ankurdotb
ci: Add linting for proto files [DEV-1786] (#405)
dc84d56 
* Add protobuf linting
* Add ignore for v1 protos
* Keep only buf linter
* Inherit secrets
* Buf lint and breaking configuration

Co-authored-by: Ankur Banerjee <ankurdotb@users.noreply.github.com>
@ankurdotb
Merge branch 'develop' into proto-v2
d859900
@ankurdotb
Update dispatch.yml
b3531d9
@ankurdotb
Fix proto lint stage
2a3eaf3
@askolesov
Copy link
Contributor Author

Todo: Add deactivation transaction

@askolesov askolesov merged commit 7a52828 into develop Oct 26, 2022
@askolesov askolesov deleted the proto-v2 branch October 26, 2022 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lampkin-diet lampkin-diet Awaiting requested review from lampkin-diet

@ankurdotb ankurdotb Awaiting requested review from ankurdotb

@Eengineer1 Eengineer1 Awaiting requested review from Eengineer1

Assignees
No one assigned
Labels
hacktoberfest-accepted
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@askolesov @ankurdotb @Eengineer1