test: Move unit testing to Gingko [DEV-1652] #373
Conversation
|
Task linked: DEV-1652 cheqd-node tests refactoring |
|
Nice work, I like Gingko as well! BTW, did you guys know or had a chance to look at GoConvey? It's a very interesting alternative for more behavioral-oriented testing. Could be interesting to have a look and see if it could potentially help us in the direction we are aiming for. Well done! |
ankurdotb
changed the title
|
All changes are structural and related to the introduction of Gingko as a supporting library for testing. However, in practical terms, I can't see too many changes or improvements in regards to the quality of test scenarios in general towards a more realistic and behavioral-driven approach. I'm suggesting that we either merge or close this, since it will have an impact going forward on what library we will utilize, and I personally believe that there could be better alternatives to Gingko, like GoConvey, which could give us more behavioral-driven tests. I'm keen on hearing others opinions on the matter as well, and if we can take a decision here without having to wait for @ankurdotb that would be better, otherwise this PR could get really behind and the code may rot. |
drgomesp
force-pushed
the
DEV-1652
branch
16 times, most recently
from
377b9c0 to
5b827b3
Compare
| var _ = Describe("DID-URL tests", func() { | ||
| DescribeTable("Check the DID-URL join functionality (without functionality)", |
| }) | ||
| When("verification method with expected multibase key", func() { | ||
| It("is valid", func() { | ||
| struct_ = VerificationMethod{ | ||
| Id: "did:cheqd:aaaaaaaaaaaaaaaa#qwe", |
There was a problem hiding this comment.
Earlier we set allowedNamespaces = []string{} which means we allow any namespaces including empty one. Agreed, let's add a test case where we expect certain namespace value.
lampkin-diet
force-pushed
the
DEV-1652
branch
from
9bd46c7 to
6d412c6
Compare
No description provided.