Authorizer: Avoid cancelling the log parser on success #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead, let the log parser stop itself when it sees MARKER_CODE_STOP, which will always be present for the success flow. The previous behavior of explicitly cancelling the log parser when Rcbridge.rbAuthorize() returns is unfortunately prone to a race condition. It turns out that logging from the golang side is not synchronous, so the log message containing the token would sometimes occur after the cancellation message. Fixes: #55 Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
chenxiaolong
added a commit
that referenced
this pull request
Apr 29, 2024
Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead, let the log parser stop itself when it sees
MARKER_CODE_STOP, which will always be present for the success flow.The previous behavior of explicitly cancelling the log parser when
Rcbridge.rbAuthorize()returns is unfortunately prone to a race condition. It turns out that logging from the golang side is not synchronous, so the log message containing the token would sometimes occur after the cancellation message.Fixes: #55