Implement basic file retention policy #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenxiaolong
force-pushed
the
retention
branch
2 times, most recently
from
970f42c to
e763fc4
Compare
The output directory selection has been moved to a new bottom sheet, which also contains a new slider for setting the file retention period. The actual cleanup functionality will be implemented in a separate commit. Signed-off-by: Andrew Gunnerson <chillermillerlong@hotmail.com>
Signed-off-by: Andrew Gunnerson <chillermillerlong@hotmail.com>
Signed-off-by: Andrew Gunnerson <chillermillerlong@hotmail.com>
chenxiaolong
added a commit
that referenced
this pull request
Jun 18, 2022
Signed-off-by: Andrew Gunnerson <chillermillerlong@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a simple file retention policy mechanism. The output directory preference now opens a bottom sheet that allows for the configuration of the file retention. The available options are hardcoded to:
The cleanup procedure runs at the end of a call recording. If eg. the file retention is set to 30 days and there are files older than 30 days, they will not be deleted until the next phone call. There is no background process to run the cleanup periodically.
The age of past recordings is determined by the filename only. In other words, the start times of the calls are used for comparison. The file modification time is completely ignored. For example, if the current time is:
and a past 2-hour recording is:
then the file is considered 25 hours old, not 23 hours.
Fixes: #25
Fixes: #81
Fixes: #88