Split pure silence warning notification to separate channel #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The warning can sometimes be triggered when hanging up before the other party is able to answer, so allow the user to disable the notification if desired. This commit also changes the recorder thread status reporting to be more explicit and type-safe. All user-facing error messages are now computed in the UI layers instead of the recorder thread. Closes: #579 Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
chenxiaolong
added a commit
that referenced
this pull request
Aug 10, 2024
Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The warning can sometimes be triggered when hanging up before the other party is able to answer, so allow the user to disable the notification if desired.
This commit also changes the recorder thread status reporting to be more explicit and type-safe. All user-facing error messages are now computed in the UI layers instead of the recorder thread.
Closes: #579