Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare for API 34 update #377

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Prepare for API 34 update #377

merged 1 commit into from
Jul 10, 2023

Conversation

PatrykMis
Copy link
Contributor

@PatrykMis PatrykMis commented Jul 10, 2023 •
edited
Loading

Fixes #376, hope I did it right.

For full API 34 compatibility the following should be fixed: https://developer.android.com/reference/kotlin/android/service/quicksettings/TileService#startactivityandcollapse_1

fun startActivityAndCollapse(intent: Intent!): Unit is deprecated in favor of fun startActivityAndCollapse(pendingIntent: PendingIntent): Unit

@PatrykMis
Fixes to compile under SDK 34
3d93fe7 
Signed-off-by: Patryk Miś <foss@patrykmis.com>
@chenxiaolong chenxiaolong merged commit 197c2ea into chenxiaolong:master Jul 10, 2023
@PatrykMis PatrykMis deleted the comp/api-34 branch July 10, 2023 23:18
@PatrykMis PatrykMis changed the title Fixes to compile under SDK 34 * Prepare for API 34 update Jul 10, 2023
@PatrykMis PatrykMis changed the title * Prepare for API 34 update Prepare for API 34 update Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenxiaolong chenxiaolong chenxiaolong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prepare for SDK 34
2 participants
@PatrykMis @chenxiaolong