Improve SAF performance and defer custom filename template processing to the end of the call #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On some devices, Android's Storage Access Framework is astoundingly slow. This is due to the listFiles() and findFile() implementations performing separate ContentResolver queries for every child item in the directory. This commit introduces extension methods for DocumentFile that perform these operations using only a single query. Issue: #252 Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
Simply checking for the existence of bcr.properties leads to a >500ms delay on some devices due to the slowness of SAF. Issue: #252 Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
chenxiaolong
added a commit
that referenced
this pull request
Feb 24, 2023
Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As encountered in #252, some devices have a horrendous SAF implementation that takes upwards of 8 seconds just to check for the existence of
bcr.propertiesin the output directory. The main cause of the delay is that theDocumentFile.findFile()implementation is very inefficient and performs a separate query to the document provider for each child in the directory. The first commit addresses this by reimplementing the method to use a single query.However, even with the optimized query, it still takes >500ms on some devices, so the second commit updates
RecorderThreadto defer custom filename template processing until the end of the call.To illustrate the absurdity of this slowness, when using native
Files with the default output directory (no-SAF) on the same device, the same set of operations takes 2ms.Fixes: #252