Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ver: 1.46 - format issue #367

Closed
tdas777 opened this issue Jul 2, 2023 · 5 comments · Fixed by #368
Closed

Ver: 1.46 - format issue #367

tdas777 opened this issue Jul 2, 2023 · 5 comments · Fixed by #368
Assignees
@chenxiaolong
Labels
bug Bug in BCR itself

Comments

@tdas777
Copy link

tdas777 commented Jul 2, 2023 •
edited
Loading

I have selected m4a/aac as recording format, but all my call recordings are saved with mp3 extension.

General
Complete name : E:********************.mp3
Format : MPEG-4
Format profile : Base Media / Version 2
Codec ID : mp42 (isom/mp42)
File size : 13.0 KiB
Duration : 3 s 280 ms
Overall bit rate mode : Constant
Overall bit rate : 32.4 kb/s
Encoded date : UTC 2023-07-02 15:45:16
Tagged date : UTC 2023-07-02 15:45:16
com.android.version : 13
com.android.manufacturer : OnePlus
com.android.model : LE2101
FileExtension_Invalid : braw mov mp4 m4v m4a m4b m4p m4r 3ga 3gpa 3gpp 3gp 3gpp2 3g2 k3g jpm jpx mqv ismv isma ismt f4a f4b f4v

Audio
ID : 1
Format : AAC LC SBR
Format/Info : Advanced Audio Codec Low Complexity with Spectral Band Replication
Commercial name : HE-AAC
Format settings : NBC
Codec ID : mp4a-40-5
Duration : 3 s 280 ms
Source duration : 3 s 323 ms
Source_Duration_LastFrame : 37 ms
Bit rate mode : Constant
Bit rate : 24.0 kb/s
Channel(s) : 1 channel
Channel layout : C
Sampling rate : 48.0 kHz
Frame rate : 23.438 FPS (2048 SPF)
Compression mode : Lossy
Stream size : 9.71 KiB (75%)
Source stream size : 9.71 KiB (75%)
Title : SoundHandle
Language : English
Encoded date : UTC 2023-07-02 15:45:16
Tagged date : UTC 2023-07-02 15:45:16
mdhd_Duration : 3280
@chenxiaolong chenxiaolong self-assigned this Jul 2, 2023
@chenxiaolong
Copy link
Owner

Format : MPEG-4
...
Commercial name : HE-AAC

It looks like the actual file format is AAC, but the file extension is wrong. Can you enable debug mode by long pressing BCR's version number, make a call, and then upload the log file that gets created in the output directory?

I suspect this is a bug in the Android ROM you're using though. Android is responsible for determining the file extension, not BCR.

@tdas777
Copy link
Author

tdas777 commented Jul 2, 2023

PFA log
20230703_024932.006+0530_out_198.log[1].txt

@chenxiaolong
Copy link
Owner

Thanks for the logs. This might actually be a BCR bug. I'm looking into it now.

chenxiaolong added a commit that referenced this issue Jul 2, 2023
@chenxiaolong
Explicitly specify MIME type when moving files
2693658 
This fixes a regression in #361, which reintroduced #292/#293.

Fixes: #367

Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
@chenxiaolong chenxiaolong mentioned this issue Jul 2, 2023
Merged
@chenxiaolong
Copy link
Owner

This is fixed in #368, which will be included in version 1.47.

For your existing recordings, you can just manually rename them from .mp3 back to .m4a since the file contents is already a valid M4A/AAC file.

@chenxiaolong chenxiaolong added the bug Bug in BCR itself label Jul 2, 2023
@tdas777
Copy link
Author

tdas777 commented Jul 3, 2023

Thanks. Love this project <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chenxiaolong chenxiaolong

Labels
bug Bug in BCR itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Explicitly specify MIME type when moving files chenxiaolong/BCR
2 participants
@chenxiaolong @tdas777