-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for additional (low-bitrate, lossy) codecs #21
Comments
I was able to successfully test opus in an ogg container. Now, onto vorbis in an ogg container. |
Hmm, Android doesn't actually support ogg/vorbis encoding. The only audio encoders available on the Pixel 6 Pro are:
|
Looks like So we'll have 3 options:
|
This commit adds the initial framework for allowing the configuration of output codecs. There are three codec choices available: * FLAC: (default) lossless, compression level 0-8 * OGG/Opus: lossy, bitrate 6-510kbps, Android 10+ only * M4A/AAC: lossy, HE-AAC bitrate 24-32kbps, AAC-LC bitrate 32-128kbps While all three codecs are implemented, RecorderThread is currently hardcoded to use the default. The next step is to save and load the codec configuration from SharedPreferences and the finally add the user interface. Issue: #21 Signed-off-by: Andrew Gunnerson <chillermillerlong@hotmail.com>
This commit adds the initial framework for allowing the configuration of output codecs. There are three codec choices available: * FLAC: (default) lossless, compression level 0-8 * OGG/Opus: lossy, bitrate 6-510kbps, Android 10+ only * M4A/AAC: lossy, HE-AAC bitrate 24-32kbps, AAC-LC bitrate 32-128kbps While all three codecs are implemented, RecorderThread is currently hardcoded to use the default. The next step is to save and load the codec configuration from SharedPreferences and the finally add the user interface. Issue: #21 Signed-off-by: Andrew Gunnerson <chillermillerlong@hotmail.com>
I guess developer is already adding supporting for M4A/AAC. As per developer's comment, default is FLAC and user will have the choice to select the codecs (FLAC, OGG/Opus, M4A/AAC) in coming release I guess. |
Yes, They're!🤞 |
…erences Issue: #21 Signed-off-by: Andrew Gunnerson <chillermillerlong@hotmail.com>
Issue: #21 Signed-off-by: Andrew Gunnerson <chillermillerlong@hotmail.com>
…erences Issue: #21 Signed-off-by: Andrew Gunnerson <chillermillerlong@hotmail.com>
Issue: #21 Signed-off-by: Andrew Gunnerson <chillermillerlong@hotmail.com>
…erences Issue: #21 Signed-off-by: Andrew Gunnerson <chillermillerlong@hotmail.com>
Issue: #21 Signed-off-by: Andrew Gunnerson <chillermillerlong@hotmail.com>
Issue: #21 Signed-off-by: Andrew Gunnerson <chillermillerlong@hotmail.com>
The configuration is implemented as a bottom sheet that appears when clicking the new output format preferences. Changes are applied immediately and per-codec configuration values are preserved when switching codecs. Issue: #21 Signed-off-by: Andrew Gunnerson <chillermillerlong@hotmail.com>
The configuration is implemented as a bottom sheet that appears when clicking the new output format preferences. Changes are applied immediately and per-codec configuration values are preserved when switching codecs. Issue: #21 Signed-off-by: Andrew Gunnerson <chillermillerlong@hotmail.com>
The configuration is implemented as a bottom sheet that appears when clicking the new output format preferences. Changes are applied immediately and per-codec configuration values are preserved when switching codecs. Issue: #21 Signed-off-by: Andrew Gunnerson <chillermillerlong@hotmail.com>
The configuration is implemented as a bottom sheet that appears when clicking the new output format preferences. Changes are applied immediately and per-codec configuration values are preserved when switching codecs. Issue: #21 Signed-off-by: Andrew Gunnerson <chillermillerlong@hotmail.com>
The configuration is implemented as a bottom sheet that appears when clicking the new output format preferences. Changes are applied immediately and per-codec configuration values are preserved when switching codecs. Issue: #21 Signed-off-by: Andrew Gunnerson <chillermillerlong@hotmail.com>
This has been implemented and will be available in the next version! I ended up making OGG/Opus the default. I figure most people will probably prefer (much) smaller files over FLAC's 0 quality loss. |
…codec is selected Issue: #21 Signed-off-by: Andrew Gunnerson <chillermillerlong@hotmail.com>
…codec is selected Issue: #21 Signed-off-by: Andrew Gunnerson <chillermillerlong@hotmail.com>
Thank you, I'm sure this will be more useful compared to lossless big files. |
I know I said in the README that this would not be implemented, but it seems like a useful enough feature to implement. I'll consider adding lossy compression formats if Android's
MediaCodec
's encoders for them aren't buggy.Tentative plan:
OGG/Vorbis(EDIT: M4A/AAC, see below) codecsWhat will not be implemented:
VOICE_LINE
is 48kHz)m4a/aac(EDIT: see below), or any other codec that might be patent encumbered in some countriesThe text was updated successfully, but these errors were encountered: