-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve contours caching calculation #3243
base: main
Are you sure you want to change the base?
Conversation
Deploying nmrium with Cloudflare Pages
|
@hamed-musallam This is the POC of the cache. I just quickly did it as a global variable but it should of course be done at the level of each spectra using I guess a useRef. I also did a small fix in ml-conrec to improve performances when nothing should be calculated. Once done we will ask Michael to check if it is ok. |
If a check the size of the cache
I read 414. There could be an issue with rounding calculating the different levels ? I think calculate the possible levels should be done once for ever per spectrum to avoid this issue. |
723f106
to
5c12840
Compare
No description provided.