-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: export as JCAMP-DX includes all metadata #3162
Merged
hamed-musallam
merged 7 commits into
main
from
3160-export-as-jcamp-dx-should-be-more-specific
Aug 5, 2024
Merged
feat: export as JCAMP-DX includes all metadata #3162
hamed-musallam
merged 7 commits into
main
from
3160-export-as-jcamp-dx-should-be-more-specific
Aug 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying nmrium with Cloudflare Pages
|
@jobo322 I think you should revert this package-lock change |
jobo322
force-pushed
the
3160-export-as-jcamp-dx-should-be-more-specific
branch
from
August 1, 2024 13:42
77695a1
to
0c03e09
Compare
We should not have this checkbox to save only real but the drop-down menu should depends on the files we have. If original is FID we should add in the menu:
If original is FT we should add in the menu depending if we are real or real + imaginary
The same is true for processed depending if it is FID, real or real + imaginary. |
hamed-musallam
force-pushed
the
3160-export-as-jcamp-dx-should-be-more-specific
branch
from
August 1, 2024 16:00
be173d6
to
480b6d6
Compare
hamed-musallam
force-pushed
the
3160-export-as-jcamp-dx-should-be-more-specific
branch
from
August 2, 2024 07:07
4edd061
to
daa2e24
Compare
hamed-musallam
force-pushed
the
3160-export-as-jcamp-dx-should-be-more-specific
branch
from
August 2, 2024 07:38
daa2e24
to
96895ae
Compare
lpatiny
changed the title
fix export as jcamp dx with all metadata
feat: export as JCAMP-DX includes all metadata
Aug 5, 2024
hamed-musallam
deleted the
3160-export-as-jcamp-dx-should-be-more-specific
branch
August 5, 2024 11:47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.