Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix simulation of only negatives chemical shift #2475

Conversation

jobo322
Copy link
Member

@jobo322 jobo322 commented Jun 26, 2023

  • handle errors in generate spectrum from ranges
  • handle errors in join couplings

prevent crash when a prediction (carbon or proton) is missing.

@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Patch coverage: 30.95% and project coverage change: -0.03 ⚠️

Comparison is base (293d2fb) 52.08% compared to head (c548924) 52.05%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2475      +/-   ##
==========================================
- Coverage   52.08%   52.05%   -0.03%     
==========================================
  Files          52       52              
  Lines        2546     2553       +7     
  Branches       84       84              
==========================================
+ Hits         1326     1329       +3     
- Misses       1217     1222       +5     
+ Partials        3        2       -1     
Impacted Files Coverage Δ
...pectrum1D/generateSpectrumFromPublicationString.ts 33.33% <0.00%> (-3.04%) ⬇️
...1d/Spectrum1D/ranges/generateSpectrumFromRanges.ts 30.61% <0.00%> (-2.00%) ⬇️
src/data/data1d/Spectrum1D/ranges/detectSignal.ts 90.81% <86.66%> (-0.59%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jun 26, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: c548924
Status: ✅  Deploy successful!
Preview URL: https://ea4d75c2.nmrium.pages.dev
Branch Preview URL: https://2474-crash-when-try-to-simul.nmrium.pages.dev

View logs

@targos
Copy link
Member

targos commented Jun 27, 2023

Can you update your PR title to something meaningful? I doubt this is adding a crash.

@jobo322 jobo322 changed the title crash when try to simulate only negatives chemical shift fix simulation of only negatives chemical shift Jun 27, 2023
@jobo322 jobo322 linked an issue Jun 28, 2023 that may be closed by this pull request
@jobo322 jobo322 requested a review from lpatiny June 28, 2023 13:30
@targos
Copy link
Member

targos commented Jun 30, 2023

Included in #2488

@targos targos closed this Jun 30, 2023
@targos targos deleted the 2474-crash-when-try-to-simulate-only-negatives-chemical-shift branch June 30, 2023 12:07
@targos targos mentioned this pull request Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants