-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix modals style and general preferences #2377
Fix modals style and general preferences #2377
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #2377 +/- ##
=======================================
Coverage 52.05% 52.05%
=======================================
Files 52 52
Lines 2553 2553
Branches 84 84
=======================================
Hits 1329 1329
Misses 1222 1222
Partials 2 2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The goal of react-science
is to take care of the style of common components as much as possible. We should do general changes to the style of modals in react-science
so it benefits other projects and doesn't make nmrium more complex.
Also I think in this case, the styles for the body of the about dialog (color of links, bullet points, size of image, etc) is very specific and should not be applied to other modals.
Can you please open a PR on react-science
with a subset of the changes that we can review?
…ces-dialog-box-should-be-centered-vertically
Deploying with Cloudflare Pages
|
Here's the PR that will allow us to change header text position in |
What is the modal for which you want to change the header position? |
I have to change the position of general preferences and about us modals and it's already fixed |
…e-centered-vertically
I have trouble to understand what this PR does. I see it adds "maxWidth" property, but there is no difference between this PR and https://dev.nmrium.org (main branch), whatever is the size of the browser window. |
I followed what Daniel mentioned here #1771 (comment) to check if there any difference. Now i'm trying to change modal content style so it will adapt screen size |
…ces-dialog-box-should-be-centered-vertically
closes: #1771