Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: firefox test #2256

Closed
wants to merge 2 commits into from
Closed

fix: firefox test #2256

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50f5f86
test: filters baselineCorrection in firefox
wadjih-bencheikh18 Mar 22, 2023
bee12ad
refactor: add todo in baselineCorrection apply btn
wadjih-bencheikh18 Mar 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion test-e2e/panels/filters.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,10 @@ async function baselineCorrectionFilter(
} else {
await nmrium.clickTool('baselineCorrection');
}
await nmrium.page.click('button >> text=Apply');
// TODO: find why the click event in the button center was being intercepted by a <dialog> element in firefox test
await nmrium.page.click('button >> text=Apply', {
wadjih-bencheikh18 marked this conversation as resolved.
Show resolved Hide resolved
position: { x: 0, y: 0 },
});

await expect(
nmrium.page.locator('_react=FilterTable >> text=Baseline correction'),
Expand Down