Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: export as JCAMP-DX includes all metadata #3162

Merged

Conversation

jobo322
Copy link
Member

@jobo322 jobo322 commented Jul 26, 2024

No description provided.

@jobo322 jobo322 linked an issue Jul 26, 2024 that may be closed by this pull request
Copy link

cloudflare-workers-and-pages bot commented Jul 26, 2024

Deploying nmrium with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9202459
Status: ✅  Deploy successful!
Preview URL: https://fade8829.nmrium.pages.dev
Branch Preview URL: https://3160-export-as-jcamp-dx-shou.nmrium.pages.dev

View logs

@lpatiny
Copy link
Member

lpatiny commented Aug 1, 2024

@jobo322 I think you should revert this package-lock change

@jobo322 jobo322 force-pushed the 3160-export-as-jcamp-dx-should-be-more-specific branch from 77695a1 to 0c03e09 Compare August 1, 2024 13:42
@lpatiny
Copy link
Member

lpatiny commented Aug 1, 2024

We should not have this checkbox to save only real but the drop-down menu should depends on the files we have.

image

If original is FID we should add in the menu:

  • Original FID

If original is FT we should add in the menu depending if we are real or real + imaginary

  • Original real
  • Original real + imaginary

The same is true for processed depending if it is FID, real or real + imaginary.

@hamed-musallam hamed-musallam force-pushed the 3160-export-as-jcamp-dx-should-be-more-specific branch from be173d6 to 480b6d6 Compare August 1, 2024 16:00
@lpatiny
Copy link
Member

lpatiny commented Aug 1, 2024

If on indometacin I do a processing (baseline correction) I would expect to see 4 items in the menu (For original and processed) but currently it is not the case. But currently I can only export the original spectrum.

image

Otherwise it looks great. Thanks !

@hamed-musallam hamed-musallam force-pushed the 3160-export-as-jcamp-dx-should-be-more-specific branch from 4edd061 to daa2e24 Compare August 2, 2024 07:07
@hamed-musallam hamed-musallam force-pushed the 3160-export-as-jcamp-dx-should-be-more-specific branch from daa2e24 to 96895ae Compare August 2, 2024 07:38
@lpatiny
Copy link
Member

lpatiny commented Aug 2, 2024

When exporting processed data we still need to check if it is still a FID or after FT.

So in the case of the FID the message should be Processed FID (always real + imaginary)

image

@lpatiny lpatiny changed the title fix export as jcamp dx with all metadata feat: export as JCAMP-DX includes all metadata Aug 5, 2024
@hamed-musallam hamed-musallam merged commit 6caf0a7 into main Aug 5, 2024
12 checks passed
@hamed-musallam hamed-musallam deleted the 3160-export-as-jcamp-dx-should-be-more-specific branch August 5, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export as JCAMP-DX should be more specific
3 participants