Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not allow deletion of digital filter #3136

Closed
lpatiny opened this issue Jul 18, 2024 · 1 comment · Fixed by #3150 or #3143
Closed

Not allow deletion of digital filter #3136

lpatiny opened this issue Jul 18, 2024 · 1 comment · Fixed by #3150 or #3143
Assignees
@hamed-musallam
Labels
enhancement New feature or request

Comments

@lpatiny
Copy link
Member

lpatiny commented Jul 18, 2024

If you drag and drop a Bruker folder, we have automatic processing:

aspirin.zip

However, it is now possible to delete the digital filter (which seemed not the case before), and we cannot put it back once deleted.

The digital filter should not be deletable, but only could be disabled.
@lpatiny lpatiny added the enhancement New feature or request label Jul 18, 2024
@lpatiny lpatiny mentioned this issue Jul 18, 2024
Closed
@hamed-musallam
Copy link
Member

hamed-musallam commented Jul 22, 2024 •
edited
Loading

Resolved by https://github.com/cheminfo/nmr-load-save/pull/407

hamed-musallam added a commit that referenced this issue Jul 23, 2024
@hamed-musallam
fix: do not allow deletion of digital filter
7e007bd 
chore: update nmr-load-save to version 0.35.1

close #3136
@hamed-musallam hamed-musallam mentioned this issue Jul 23, 2024
Merged
hamed-musallam added a commit that referenced this issue Jul 23, 2024
@hamed-musallam
fix: do not allow deletion of digital filter
e41fa05 
chore: update nmr-load-save to version 0.35.1

close #3136
@cheminfo-bot cheminfo-bot mentioned this issue Jul 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hamed-musallam hamed-musallam

Labels
enhancement New feature or request
Projects
NMR and Cheminfo projects organisation
Archived in project
Milestone
No milestone
2 participants
@lpatiny @hamed-musallam