Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Base line correction bug #2348

Closed
lpatiny opened this issue May 10, 2023 · 0 comments · Fixed by #2504 or #2503
Closed

Base line correction bug #2348

lpatiny opened this issue May 10, 2023 · 0 comments · Fixed by #2504 or #2503
Assignees
@hamed-musallam

Comments

@lpatiny
Copy link
Member

lpatiny commented May 10, 2023

When applying a polynomial baseline correction the grey zone corresponding the to selected area to use for the baseline correction should be hidden.

They should only appear and be removable when the baseline correction tool is selected.

2023-05-10 06 47 41
hamed-musallam added a commit that referenced this issue Jul 7, 2023
@hamed-musallam
fix: baseline correction should visibility
da2ff6c 
They should only appear and be removable when the baseline correction tool is selected.

close #2348
@hamed-musallam hamed-musallam linked a pull request Jul 7, 2023 that will close this issue
fix: baseline correction zones visibility #2504
Merged
@hamed-musallam hamed-musallam mentioned this issue Jul 7, 2023
Merged
hamed-musallam added a commit that referenced this issue Jul 7, 2023
@hamed-musallam
fix: baseline correction should visibility
c3a8dfe 
They should only appear and be removable when the baseline correction tool is selected.

close #2348
hamed-musallam added a commit that referenced this issue Jul 7, 2023
@hamed-musallam
fix: baseline correction zones visibility
dafe531 
They should only appear and be removable when the baseline correction tool is selected.

close #2348
hamed-musallam added a commit that referenced this issue Jul 7, 2023
@hamed-musallam
fix: baseline correction zones visibility
0f27e2f 
They should only appear and be removable when the baseline correction tool is selected.

close #2348
@cheminfo-bot cheminfo-bot mentioned this issue Jul 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hamed-musallam hamed-musallam

Labels
None yet
Projects
NMR and Cheminfo projects organisation
Archived in project
Milestone
No milestone
2 participants
@lpatiny @hamed-musallam