refactor: memoize the usePanelPreferences hook

cheminfo · Aug 29, 2024 · 08739b2 · 08739b2
1 parent 26d86f3
commit 08739b2
Showing 1 changed file with 5 additions and 7 deletions.
diff --git a/src/component/hooks/usePanelPreferences.ts b/src/component/hooks/usePanelPreferences.ts
@@ -167,13 +167,11 @@ export function usePanelPreferencesByNuclei<T extends Panel>(
 ): UsePanelPreferencesByNucleiResult<T> {
   const { current } = usePreferences();
 
-  // eslint-disable-next-line @typescript-eslint/no-unused-vars
-  const { nuclei: omitNuclei = null, ...restPreferences } = getPanelPreferences(
-    current,
-    panelKey,
-  );
-
   return useMemo(() => {
+    // eslint-disable-next-line @typescript-eslint/no-unused-vars
+    const { nuclei: omitNuclei = null, ...restPreferences } =
+      getPanelPreferences(current, panelKey);
+
     return {
       nuclei: Object.fromEntries(
         nuclei.map((nucleusLabel) => [
@@ -183,5 +181,5 @@ export function usePanelPreferencesByNuclei<T extends Panel>(
       ),
       ...restPreferences,
     };
-  }, [current, nuclei, panelKey, restPreferences]);
+  }, [current, nuclei, panelKey]);
 }