Fix windows 2008 hostname truncation #554
Conversation
…stname'] returns only the first 15 characters of the hostname--this breaks for machines with hostnames longer than 15 chars. This commit changes the WMI attribute that populates node['hostname'] to be one that provides the full hostname. The truncated version is preserved in 'machinename'.
|
Hi. I am an automated pull request bot named Curry. There are commits in this pull request whose authors are not yet authorized to contribute to Chef Software, Inc. projects or are using a non-GitHub verified email address. To become authorized to contribute, you will need to sign the Contributor License Agreement (CLA) as an individual or on behalf of your company. You can read more on Chef's blog. GitHub Users Who Are Not Authorized To ContributeThe following GitHub users do not appear to have signed a CLA:
|
|
Hi. Your friendly Curry bot here. Just letting you know that all commit authors have become authorized to contribute. I have added the "Signed CLA" label to this issue so it can easily be found in the future. |
|
ping @chef/client-windows |
|
DNSHostName seems to return the right thing on my computer and that property has been available since Win 2003+. I'm ok with this change. 👍 |
Fix windows 2008 hostname truncation
On Windows 2008 R2 (and possibly other versions of Windows),
node['hostname']returns only the first 15 characters of the hostname--this breaks for machines with hostnames longer than 15 chars. This commit changes the WMI attribute that populatesnode['hostname']to be one that provides the full hostname. The truncated version is preserved inmachinename.