Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set connection_protocol and connection_port as default before the create instance #630

Merged
merged 1 commit into from
Dec 27, 2019
Merged

Set connection_protocol and connection_port as default before the create instance #630

merged 1 commit into from
Dec 27, 2019

Conversation

kapilchouhan99
Copy link

Signed-off-by: Kapil Chouhan kapil.chouhan@msystechnologies.com

Description

  • Added plugin_setup! method
  • When options connection_protocol and connection_port are not provided then It will set as default
  • Ensured chef-style on the code changes made

Issues Resolved

Fixed: #627

Check List

Fix for knife ec2 server create command bootstrap windows node
8e55833 
Signed-off-by: Kapil Chouhan <kapil.chouhan@msystechnologies.com>
@kapilchouhan99 kapilchouhan99 requested a review from tas50 December 23, 2019 11:57
@kapilchouhan99 kapilchouhan99 self-assigned this Dec 23, 2019
@tas50 tas50 merged commit c37d88e into master Dec 27, 2019
@chef-expeditor chef-expeditor bot deleted the Kapil/MSYS-1222_knife_ec2_server_create_should_bootstrap_windows_node branch December 27, 2019 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tas50 tas50 Awaiting requested review from tas50

Assignees

@kapilchouhan99 kapilchouhan99

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@kapilchouhan99 @tas50