Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing credential error for aws-profile #621

Conversation

dheerajd-msys
Copy link
Contributor

@dheerajd-msys dheerajd-msys commented Dec 6, 2019

Signed-off-by: dheerajd-msys dheeraj.dubey@msystechnologies.com

Description

  • During ec2 server create we were getting unable to sign request without credentials set error for specified aws-profile in aws_credential_file.
  • Method connection_protocol was named same in ec2 as well as in chef so previously validate_protocol method was calling connection_protocol from chef rather than from ec2 and this resulted into nil credentials.
  • Renaming connection_protocol method helps invoking method from ec2 and fixes the issue.

Issues Resolved

Fixes #617

Check List

@dheerajd-msys dheerajd-msys self-assigned this Dec 6, 2019
@dheerajd-msys dheerajd-msys force-pushed the dh/MSYS-1201_fix_missing_credential_error_aws_profile branch from b9c7b21 to 7770d99 Compare December 13, 2019 09:46
@tas50
Copy link
Contributor

tas50 commented Dec 16, 2019

@dheerajd-msys Can you rebase this on master and take a look at the failure in buildkite please?

@dheerajd-msys
Copy link
Contributor Author

Yes @tas50 I am going to do that now.
Thanks 👍

Signed-off-by: dheerajd-msys <dheeraj.dubey@msystechnologies.com>
Signed-off-by: dheerajd-msys <dheeraj.dubey@msystechnologies.com>
Signed-off-by: dheerajd-msys <dheeraj.dubey@msystechnologies.com>
@dheerajd-msys dheerajd-msys force-pushed the dh/MSYS-1201_fix_missing_credential_error_aws_profile branch from 7770d99 to 3bc69f0 Compare December 17, 2019 07:22
@tas50 tas50 merged commit f0c40b8 into chef:master Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Aws::Errors::MissingCredentialsError: unable to sign request without credentials set
4 participants