Modified create_ssl_listener option as per Mixlib-CLI. #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It'd be nice if we could avoid having to add and remove the config setting in so many tests, but otherwise 👍 |
|
@btm I have removed multiple add and delete entries for config[:create_ssl_listener] variable from the specs. Please have a look and let me know if any issues still persist. |
NimishaS
force-pushed
the
ali/change_create_no_ssl_listener
branch
from
dde6ca3 to
68474e3
Compare
NimishaS
pushed a commit
that referenced
this pull request
Nov 30, 2015
…_ssl_listener Modified create_ssl_listener option as per Mixlib-CLI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made changes in code for --[no-]create-ssl-listener option as per Mixlib-CLI's magic and also modified RSpecs to accommodate the changes.