Add a cop for detecting legacy powershell methods #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We shouldn't use these anywhere now that we have the improved methods Signed-off-by: Tim Smith <tsmith@chef.io>
tas50
added
the
Expeditor: Bump Version Minor
jaymzh
approved these changes
Jan 22, 2021
config/chefstyle.yml
Outdated
| Description: Use powershell_exec!/powershell_exec instead of the slower legacy powershell_out!/powershell_out methods. | ||
| Enabled: true | ||
| VersionAdded: '1.6.0' |
There was a problem hiding this comment.
why does your editor not properly end files? :(
There was a problem hiding this comment.
I turned it on now just for you. It causes a lot of issues with other projects that get grumpy about newlines
|
It's not really something we can autocorrect since it returns a totally different type of data. You have to refactor (for the better) the code to use the new method. |
jaymzh
reviewed
Jan 22, 2021
| end | ||
| end | ||
| end | ||
| end |
Signed-off-by: Tim Smith <tsmith@chef.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't use these anywhere now that we have the improved methods
Signed-off-by: Tim Smith tsmith@chef.io