Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't run disable system restore on windows servers #1530

Merged
merged 2 commits into from
Sep 23, 2023
Merged

don't run disable system restore on windows servers #1530

merged 2 commits into from
Sep 23, 2023

Conversation

Stromweld
Copy link
Collaborator

Description

Disable running the disable system restore script on windows servers since they don't have system restore

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@Stromweld Stromweld requested review from a team as code owners September 21, 2023 14:14
@Stromweld Stromweld self-assigned this Sep 21, 2023
@Stromweld Stromweld requested a review from a team as a code owner September 21, 2023 14:14
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Stromweld Stromweld merged commit 53462a1 into main Sep 23, 2023
@Stromweld Stromweld deleted the win-fix branch September 23, 2023 20:57
hunleyd added a commit to hunleyd/bento that referenced this pull request Nov 23, 2023
@hunleyd
Merge branch 'main' of github.com:chef/bento
f6c08aa 
* 'main' of github.com:chef/bento:
  don't try to disable system restore on servers (chef#1530)
  Avoid downloading application to implement eject-media (chef#1529)
raykrist pushed a commit to norcams/bento that referenced this pull request Aug 19, 2024
@Stromweld @raykrist
don't try to disable system restore on servers (chef#1530)
5197b53 
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Stromweld Stromweld

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Stromweld