Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added vagrant upload account configuration in builds.yml #1522

Merged
merged 23 commits into from
Sep 15, 2023
Merged

added vagrant upload account configuration in builds.yml #1522

merged 23 commits into from
Sep 15, 2023

Conversation

Stromweld
Copy link
Collaborator

Description

added vagrant upload account configuration in builds.yml and defaulting hyperv to generation 2

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@Stromweld
added vagrant upload account configuration in builds.yml and defaulti…
ca8d8a4 
…ng hyperv to generation 2

Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
@Stromweld Stromweld self-assigned this Aug 14, 2023
Stromweld added 18 commits August 15, 2023 16:12
@Stromweld
hyperv gen2 updates
b99a8c1 
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
@Stromweld
fmt fix
447094f 
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
@Stromweld
update kitchen box names
a9a9779 
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
@Stromweld
workflow updates
aaec401 
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
@Stromweld
test
0b4ca94 
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
@Stromweld
cleaning up EOL builds
a1714d0 
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
@Stromweld
removed chef-solo plugin
29ace4f 
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
@Stromweld
updates
fbb47e5 
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
@Stromweld
added bento testing to builds
fe3e92f 
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
@Stromweld
merged main
922f53e 
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
@Stromweld
fix tests
5812310 
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
@Stromweld
add boot_wait variables for each provider, added --vars and --var_fil…
54b2ff0 
…es flags, fixed upload description for libvirt to add qemu hv and version, removed debian 10, updated ubuntu 20.04 boot_command, changed workflows to be based on cpu architecture

Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
@Stromweld
updated changelog
b10f095 
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
@Stromweld
fix exit with errored builds
2e7c796 
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
@Stromweld
update changelog and readme
b5e4de7 
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
@Stromweld
comment out tests for now
7b159be 
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
@Stromweld
bento tweaks
a080bf7 
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
@Stromweld
test
0e88bc0 
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
@hunleyd
Copy link

hunleyd commented Sep 12, 2023

hey @Stromweld for those of us who use this repo to manage our own 'fleet' of Vagrant images for our company.. do you have plans to expand this PR to allow us to specify the account name and if the box should be public/private? Or is this just for bento use and we should continue to use our current upload logic?

@Stromweld
Copy link
Collaborator Author

Once this is merged in the builds.yml file you can specify the account you want vagrant to upload the boxes to. it'll default to bento but if you manage your own fork then you can change it to your account. You simply need to have logged-in to the account with the vagrant cli for the session token. Bento is simply then running vagrant cloud plublish <acct_name>/<box_name> command. You'll get the same box names and descriptions as the bento released ones though.

@Stromweld
Copy link
Collaborator Author

Currently it's publishing all boxes publicly but I can add to it the ability to define in the builds.yml file which will be public and default to private otherwise.

@Stromweld
add ability to configure bento upload of public or private boxes.
1043073 
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
@Stromweld
added scripts variable
f48cbec 
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
@Stromweld
update changelog version
edc2ffa 
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
@Stromweld Stromweld marked this pull request as ready for review September 15, 2023 19:00
@Stromweld Stromweld requested review from a team as code owners September 15, 2023 19:00
@Stromweld Stromweld requested a review from a team as a code owner September 15, 2023 19:00
@Stromweld
add bento upload command to the readme
28b7bff 
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Stromweld Stromweld merged commit e3da652 into main Sep 15, 2023
@Stromweld Stromweld deleted the updates branch September 15, 2023 21:08
hunleyd added a commit to hunleyd/bento that referenced this pull request Sep 18, 2023
@hunleyd
Merge branch 'main' of github.com:chef/bento
6aa71a1 
* 'main' of github.com:chef/bento:
  added vagrant upload account configuration in builds.yml (chef#1522)
raykrist pushed a commit to norcams/bento that referenced this pull request Aug 19, 2024
@Stromweld @raykrist
added vagrant upload account configuration in builds.yml (chef#1522)
afacbd3 
* Added bento upload to use vagrant account configured in builds.yml
* Updated windows vagrant template to default to 4GB of memory
* Default hyper-v to generation 2
* Removed EOL OS builds Windows2012r2, Ubuntu 18.04, Ubuntu 22.10, Debian 10
* Remove use of deprecated chef-solo provisioner and cookbooks for windows builds
* Add boot_wait variables for each provider
* Adjusted default_boot_wait for linux to 5s
* Added --vars and --var_files flags
* Fixed upload description for libvirt to add qemu hv and version
* Updated ubuntu 20.04 boot_command
* Changed workflows to be based on cpu architecture
* Updated Bento to continue builds even if one fails and report all failures at the end and exit with exit code 1
* Added qemu clone of libvirt box when metadata file is created for uploading to vagrant qemu provider
* Made build shell scripts customizable through packer variable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Stromweld Stromweld

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Stromweld @hunleyd