make the check port changes for chef-managed database for automate ha #8613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: punitmundra <pmundra@progress.com>
👷 Deploy Preview for chef-automate processing.
|
vivek-yadav
reviewed
Sep 26, 2024
Comment on lines
78
to
102
| # Compare major versions | ||
| if (( major1 > major2 )); then | ||
| echo "$installed_version is greater than $airgap_bundle_version" | ||
| isSkipRequired=true | ||
| elif (( major1 < major2 )); then | ||
| echo "$airgap_bundle_version is greater than $installed_version, proceeding for upgrade" | ||
| else | ||
| # Compare minor versions | ||
| if (( minor1 > minor2 )); then | ||
| echo "$installed_version is greater than $airgap_bundle_version" | ||
| isSkipRequired=true | ||
| elif (( minor1 < minor2 )); then | ||
| echo "$airgap_bundle_version is greater than $installed_version, proceeding for upgrade" | ||
| else | ||
| # Compare patch versions | ||
| if (( patch1 > patch2 )); then | ||
| echo "$installed_version is greater than $airgap_bundle_version" | ||
| isSkipRequired=true | ||
| elif (( patch1 < patch2 )); then | ||
| echo "$airgap_bundle_version is greater than $installed_version, proceeding for upgrade" | ||
| else | ||
| echo "Both versions are equal" | ||
| fi | ||
| fi | ||
| fi |
There was a problem hiding this comment.
can we do some unit testing by putting it in a function ?
vivek-yadav
reviewed
Sep 26, 2024
| @@ -55,10 +55,10 @@ backend automate_postgresql | |||
| {{~#if ../cfg.resolvers.nameservers }} | |||
| server-template {{node.address}} 8 {{node.address}}:{{node.port}} check resolvers pgdns init-addr none resolve-prefer ipv4 | |||
| {{else}} | |||
| server {{node.address}} {{node.address}}:{{node.port}} maxconn {{../cfg.max_connections}} check port 6432 | |||
| server {{node.address}} {{node.address}}:{{node.port}} maxconn {{../cfg.max_connections}} {{~#if ../cfg.chef_manage_db }} check port 6432 {{~/if}} | |||
There was a problem hiding this comment.
can we put the maxconn into the if condition, since earlier the maxconn was not present for customer managed database
Signed-off-by: punitmundra <pmundra@progress.com>
Signed-off-by: punitmundra <pmundra@progress.com>
Signed-off-by: punitmundra <pmundra@progress.com>
Signed-off-by: punitmundra <pmundra@progress.com>
punitmundra
changed the title
|
vivekshankar1
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔩 Description: What code changed, and why?
https://progresssoftware.atlassian.net/browse/CHEF-16071
https://progresssoftware.atlassian.net/browse/CHEF-16072
⛓️ Related Resources
👍 Definition of Done
👟 How to Build and Test the Change
✅ Checklist
All PRs must tick these:
With occasional exceptions, all PRs from Progress employees must tick these:
make spellin any component directory)All PRs from Progress employees should tick these if appropriate:
Please add a note next to any checkbox above if you are NOT ticking it.
📷 Screenshots, if applicable