Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Node.js version 8.9.4 -> 10.15.2 #785

Merged
merged 6 commits into from
Jul 9, 2019
Merged

Bump Node.js version 8.9.4 -> 10.15.2 #785

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
092a286
Node.js version bump 8.9.4 -> 10.16.0
msorens Jul 7, 2019
9016378
npm update codelyzer
msorens Jul 7, 2019
ea40312
Remove unused @angular/http package
msorens Jul 8, 2019
1ba51ad
nvmrc: try with 10.15.2
srenatus Jul 8, 2019
136eb29
*/habitat: adjust core/node -> core/node10
srenatus Jul 8, 2019
563bd70
Resync package-lock.json with v10.15.2
msorens Jul 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .studio/automate-ui
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,8 +243,8 @@ function _maybe_rebuild_node_sass {
fi
}

# (Internal) Install nodejs from the .nvmrc file
# If it can't find that file this function will error our
# (Internal) Install nodejs from the .nvmrc file.
# If it can't find that file this function will fail.
function _install_nodejs_from_nvmrc() {
if [ ! -z "$(node -v 2>/dev/null)" ]; then
log_line "Using NodeJS $(node -v)"
Expand All @@ -259,7 +259,7 @@ function _install_nodejs_from_nvmrc() {
fi

log_line "Installing NodeJS (v.$NODE_VERSION)"
OPTS="-b" install "core/node/$NODE_VERSION" >/dev/null
OPTS="-b" install "core/node10/$NODE_VERSION" >/dev/null

install_if_missing core/git git;
install_if_missing core/coreutils env;
Expand Down
2 changes: 1 addition & 1 deletion components/automate-ui/.nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
8.9.4
10.15.2
2 changes: 1 addition & 1 deletion components/automate-ui/habitat/plan.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ pkg_deps=(
pkg_build_deps=(
core/git
core/make
core/node/"$(cat "$PLAN_CONTEXT/../.nvmrc")"
core/node10/"$(cat "$PLAN_CONTEXT/../.nvmrc")"
core/rsync
)
pkg_exports=(
Expand Down
Loading