Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Node from v 12.13.1 to 14.16.0 #4867

Closed
wants to merge 3 commits into from
Closed

Conversation

SEAjamieD
Copy link
Contributor

@SEAjamieD SEAjamieD commented Mar 23, 2021

🔩 Description: What code changed, and why?

Periodic updating of node.js version.

⛓️ Related Resources

Guide to follow: #2579

Historical:
#785 Bump Node.js version 8.9.4 -> 10.15.2 (automate-ui and chef-ui-library)
#2267 Bump Node.js version 5.6.0 -> 10.15.2 (automate-workflow-web)

Pre work

PR's in the following repos to kick off the pre work required
chef core-plans repo: habitat-sh/core-plans#3580
chef-base-plans repo: chef-base-plans/node14#2

👍 Definition of Done

  • Automate is now using node 14.16.0
  • Everything still builds and runs.
  • None of the npm install commands should generate any non-committed changes to the respective package-lock.json files.

👟 How to Build and Test the Change

✅ Checklist

📷 Screenshots, if applicable

@netlify
Copy link

netlify bot commented Mar 23, 2021

Deploy preview for chef-automate processing.

Building with commit ede0e51

https://app.netlify.com/sites/chef-automate/deploys/60621156d27019000719948b

@SEAjamieD SEAjamieD self-assigned this Mar 23, 2021
@SEAjamieD SEAjamieD changed the title Update nvmrc Bump Node from v 12.13.1 to 14.16.0 Mar 23, 2021
Signed-off-by: seajamied <jdegnan@chef.io>
seajamied added 2 commits March 29, 2021 10:38
Signed-off-by: seajamied <jdegnan@chef.io>
Signed-off-by: seajamied <jdegnan@chef.io>
@SEAjamieD
Copy link
Contributor Author

On hold until the Habitat updates are promoted

@SEAjamieD SEAjamieD removed their assignment Nov 16, 2022
@SEAjamieD SEAjamieD closed this Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant